Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reset_event_timer defaults to True in sub-sequences #194

Merged
merged 2 commits into from
Nov 1, 2024

Conversation

wl-stepp
Copy link
Contributor

@wl-stepp wl-stepp commented Nov 1, 2024

Fixes problem mentioned in #187. All events in sub-sequences had the reset_event_timer flag set to True.
#187 (comment)

I'm not sure if this is the correct position for this fix, please check if this makes sense.

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.78%. Comparing base (772f59a) to head (26a77d8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #194   +/-   ##
=======================================
  Coverage   93.77%   93.78%           
=======================================
  Files          18       18           
  Lines        1237     1238    +1     
=======================================
+ Hits         1160     1161    +1     
  Misses         77       77           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@tlambert03 tlambert03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great! Thanks for catching and fixing @wl-stepp

@tlambert03 tlambert03 merged commit 9162967 into pymmcore-plus:main Nov 1, 2024
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants